Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan Filter in Averaged Spectra #808

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Oct 25, 2024

Updated SpectraFileAveraging.cs to include the ScanFilter parameter in the MsDataScan constructor, replacing null values. This change ensures that the ScanFilter property is properly set, improving the accuracy and completeness of the scan data.

in the MsDataScan constructor, replacing null values. This change
ensures that the ScanFilter property is properly set, improving the
accuracy and completeness of the scan data.
@nbollis nbollis added bug Maintenance The user isn't impacted by it, it's purely behind the scenes labels Oct 25, 2024
@nbollis nbollis requested a review from zhuoxinshi October 25, 2024 18:05
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.55%. Comparing base (dc20e44) to head (a2cbcf7).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #808   +/-   ##
=======================================
  Coverage   76.55%   76.55%           
=======================================
  Files         212      212           
  Lines       32011    32012    +1     
  Branches     3297     3297           
=======================================
+ Hits        24507    24508    +1     
  Misses       6945     6945           
  Partials      559      559           
Files with missing lines Coverage Δ
...ectralAveraging/Algorithms/SpectraFileAveraging.cs 97.67% <100.00%> (+0.02%) ⬆️

@trishorts trishorts merged commit 7dcf9a9 into smith-chem-wisc:master Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Maintenance The user isn't impacted by it, it's purely behind the scenes ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants